Skip to content

Update 03-Container-Test.md #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update 03-Container-Test.md #22

wants to merge 1 commit into from

Conversation

aabdullin
Copy link
Contributor

No description provided.

shawnhankim
shawnhankim requested changes Dec 20, 2022
View reviewed changes
Copy link
Member

@shawnhankim shawnhankim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Thanks @aabdullin for this PR to try fixing it.
  • But, the root directory is ./nginx-oidc-onelogin so ./docker/build-context/ssl/ makes more sense, and make start also can be run in the directory of ./nginx-oidc-onelogin.
  • If you would like to add more instructions for customers' convenience, then you can add some comments like prerequisite: the working directory is ./nginx-oidc-onelogin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shawnhankim shawnhankim shawnhankim requested changes

Assignees

@shawnhankim shawnhankim

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aabdullin @shawnhankim